Connection to Pi-Hole(s) handled in goroutine #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent 8d55865 author Galorhallen <andrea.ponte1987@gmail.com> 1640558190 +0100 committer Galorhallen <andrea.ponte1987@gmail.com> 1640821760 +0100 Add test for multiple pihole Add async mode for multiple piholes Fixed GitHub Actions go versions Add test for multiple pihole Cleanup
parent 8d55865 author Galorhallen <andrea.ponte1987@gmail.com> 1640558190 +0100 committer Galorhallen <andrea.ponte1987@gmail.com> 1640821760 +0100 Add test for multiple pihole Add async mode for multiple piholes Fixed GitHub Actions go versions Add test for multiple pihole Cleanup
eko
approved these changes
Feb 20, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in this PR:
intervalconfiguration has been removedTimeoutconfiguration has been added, which controls the timeout to connect to a Pi-Hole instance.